Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convenience shortcut for Path.toBeASymbolicLink feature #811

Merged

Conversation

fimbulwint
Copy link
Contributor

For both infix and fluent API styles


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@fimbulwint fimbulwint requested a review from robstoll as a code owner February 14, 2021 10:59
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #811 (2d3b1c8) into master (fc31761) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
- Coverage   84.74%   84.74%   -0.01%     
==========================================
  Files         437      437              
  Lines        4216     4222       +6     
  Branches      225      225              
==========================================
+ Hits         3573     3578       +5     
- Misses        595      596       +1     
  Partials       48       48              
Flag Coverage Δ
bbc 77.81% <0.00%> (-0.12%) ⬇️
bc 79.80% <0.00%> (-0.12%) ⬇️
current 83.81% <71.42%> (-0.01%) ⬇️
current_windows 82.44% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/kotlin/ch/tutteli/atrium/logic/PathAssertions.kt 0.00% <ø> (ø)
...tutteli/atrium/logic/impl/DefaultPathAssertions.kt 85.50% <33.33%> (-1.06%) ⬇️
.../tutteli/atrium/api/fluent/en_GB/pathAssertions.kt 100.00% <100.00%> (ø)
...tlin/ch/tutteli/atrium/api/infix/en_GB/keywords.kt 95.23% <100.00%> (+0.23%) ⬆️
...h/tutteli/atrium/api/infix/en_GB/pathAssertions.kt 100.00% <100.00%> (ø)
...c/generated/kotlin/ch/tutteli/atrium/logic/path.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc31761...2d3b1c8. Read the comment docs.

@fimbulwint fimbulwint force-pushed the #765-shortcut-for-isSymbolicLink branch from b56f12c to a80c33b Compare February 14, 2021 12:36
Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fimbulwint thanks for your first contribution. A few improvements and we are good to merge it

@fimbulwint fimbulwint force-pushed the #765-shortcut-for-isSymbolicLink branch from 24741c2 to 2d3b1c8 Compare February 20, 2021 18:14
@robstoll robstoll merged commit b5716f0 into robstoll:master Feb 20, 2021
@robstoll robstoll linked an issue Feb 20, 2021 that may be closed by this pull request
9 tasks
@robstoll
Copy link
Owner

robstoll commented Feb 20, 2021

@fimbulwint thanks for your first contribution to Atrium 🙂 👍

We could use your help for other issues, and don't forget to ⭐ Atrium:
https://github.com/robstoll/atrium/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22

@fimbulwint
Copy link
Contributor Author

@robstoll happy to contribute 🙂

I'll take a look at some other issue when I get the chance.

@fimbulwint fimbulwint deleted the #765-shortcut-for-isSymbolicLink branch February 20, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path.toBeASymbolicLink
2 participants