fix valid commit dict #399

hsd-dev · 2021-02-03T12:45:20Z

FIxes some errors for "What is the size of the change difference?" in the Jupyter notebook.

Note: some bug files have "'bad fix hash" errors when the commit is not part of a PR:

skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/care-o-bot/ca7b536/ca7b536.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/geometry2/15b2e3c/15b2e3c.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/care-o-bot/43705f7/43705f7.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/universal_robot/89145c4/89145c4.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/geometry2/566092b/566092b.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/other/473ab5e/473ab5e.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/geometry2/e12e723/e12e723.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/geometry2/0c3aef3/0c3aef3.bug')
skipping bug [missing stats]: BugDescription(filename='/home/ipa-hsd/projects/rosin/robust/turtlebot/a4f35ee/a4f35ee.bug')

Also errors for confidential bugs since no repos.

Edit: Changes made in the PR:

generate commit statistics for the Jupyter notebook section "What is the size of the change difference?":
- fix fix commit hashes and PRs (rationale added to bug descriptions): 39724ce, 7bda2ba, bf3595c
- fix "no forks exist": 7195752, f4d6b7e
  additionally, also created forks on robust-rosin when missing.
- Identify bugs that were not fixed and set fix field to null: 73cd29f, 885c016
- Identify descriptions that are not bugs and add an identifier file NOT_A_BUG: 85a8ba1, f5d14bd
- Finally, generate commit stats from the script fetch-commit-data: bab581c
Some additional changes not related to this PR:
- Removed license field from bug description: 78dd598
  The field does not have any influence on the nature of the bug and subsequently will not influence this study.
- Correct fault-failure codes based on the discussions in Harmless flag not included in bug reports #408 and System failure code for kobuki/9de9690 #407: 0b0c8cd

motoman/045ab54/045ab54.bug

ChrisTimperley · 2021-03-16T01:24:03Z

What's the status on this one? It would be great to get this into master so we can run the notebook from there.

hsd-dev · 2021-03-16T14:01:22Z

bad fix hash:
geometry2/0c3aef3/0c3aef3.bug: This ticket addresses the issue. Apparently the fix was never merged and the functionality was moved to tf2_geometry_msgs.h
universal_robot/89145c4/89145c4.bug: Was finally fixed in ros-industrial/universal_robot#268 in ros-industrial/universal_robot@2e078f5.
geometry2/566092b/566092b.bug: the fork was created (2018-04-09) before the commit
geometry2/15b2e3c/15b2e3c.bug: just bad format
care-o-bot/ca7b536/ca7b536.bug: correct one seems to be ipa320/cob_control@47adcee
geometry2/e12e723/e12e723.bug: does not exist. Correct one is mentioned here

bugs in other have URL https://git.code.tecnalia.com, which are private repos. confidential have no hash mentioned.

hsd-dev · 2021-03-16T15:21:51Z

care-o-bot/43705f7/43705f7.bug: the PR was closed. Correct one in ipa320/cob_common@499dbb6

hsd-dev · 2021-04-28T14:09:21Z

@ChrisTimperley it should be good to be merged. Could you please review it?

ChrisTimperley

As far as I can tell by scanning through the files, this looks good.

gavanderhoorn · 2021-04-28T14:59:54Z

This PR seems to remove the license field: was that discussed somewhere?

What's the rationale?

# Conflicts: # care-o-bot/43705f7/43705f7.bug # care-o-bot/ca7b536/ca7b536.bug # geometry2/15b2e3c/15b2e3c.bug # universal_robot/89145c4/89145c4.bug

created forks for 'turtlebot_create', 'rocon_app_platform', 'turtlebot_apps', 'cob_driver', 'cob_common', 'rqt', 'gazebo_ros_pkgs', 'ecl_core', 'openni_launch', 'qt_gui_core'

robust-rosin#408 robust-rosin#407

hsd-dev · 2021-04-30T07:50:03Z

Changes made in the PR:

generate commit statistics for the Jupyter notebook section "What is the size of the change difference?":
- fix fix commit hashes and PRs (rationale added to bug descriptions): 39724ce, 7bda2ba, bf3595c
- fix "no forks exist": 7195752, f4d6b7e
  additionally, also created forks on robust-rosin when missing.
- Identify bugs that were not fixed and set fix field to null: 73cd29f, 885c016
- Identify descriptions that are not bugs and add an identifier file NOT_A_BUG: 85a8ba1, f5d14bd
- Finally, generate commit stats from the script fetch-commit-data: bab581c
Some additional changes not related to this PR:
- Removed license field from bug description: 78dd598
  The field does not have any influence on the nature of the bug and subsequently will not influence this study.
- Correct fault-failure codes based on the discussions in Harmless flag not included in bug reports #408 and System failure code for kobuki/9de9690 #407: 0b0c8cd

hsd-dev · 2021-04-30T07:50:29Z

@ChrisTimperley @gavanderhoorn @git-afsantos @wasowski

gavanderhoorn · 2021-04-30T08:07:20Z

I've copied #399 (comment) to the PR description.

hsd-dev · 2021-04-30T08:21:55Z

Edit: (Additional) changes made in the PR:

The 1st section ("generate commit statistics for the Jupyter notebook") was the purpose of the PR (referring to the "(Additional)" )

gavanderhoorn · 2021-04-30T08:39:42Z

Edit: (Additional) changes made in the PR:

The 1st section ("generate commit statistics for the Jupyter notebook") was the purpose of the PR (referring to the "(Additional)" )

please feel free to update the PR description.

I merely felt 'hiding' it in a comment somewhere down in the timeline was not the best place for such information.

hsd-dev · 2021-05-03T07:21:32Z

Thanks for your comments @ChrisTimperley and @gavanderhoorn.

hsd-dev requested a review from ChrisTimperley February 3, 2021 12:45

hsd-dev changed the title ~~fix valid commit dict~~ [WIP] fix valid commit dict Feb 3, 2021

ChrisTimperley reviewed Feb 3, 2021

View reviewed changes

motoman/045ab54/045ab54.bug Show resolved Hide resolved

hsd-dev force-pushed the fix_jupyter branch from 9b214ae to b3c468a Compare March 16, 2021 14:29

hsd-dev force-pushed the fix_jupyter branch from eb1cf63 to 9482254 Compare March 21, 2021 14:44

hsd-dev mentioned this pull request Mar 22, 2021

added fault-failure codes from excel sheet #400

Merged

hsd-dev force-pushed the fix_jupyter branch from fbac556 to 8534952 Compare March 24, 2021 13:53

hsd-dev force-pushed the fix_jupyter branch from 9173c39 to 5df1990 Compare April 14, 2021 14:44

hsd-dev changed the title ~~[WIP] fix valid commit dict~~ fix valid commit dict Apr 21, 2021

ChrisTimperley approved these changes Apr 28, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

hsd-dev mentioned this pull request Apr 28, 2021

System failure code for kobuki/9de9690 #407

Closed

hsd-dev force-pushed the fix_jupyter branch from 278c52a to 900fefe Compare April 30, 2021 06:48

hsd-dev added 12 commits April 30, 2021 08:50

fix commit hashes

39724ce

# Conflicts: # care-o-bot/43705f7/43705f7.bug # care-o-bot/ca7b536/ca7b536.bug # geometry2/15b2e3c/15b2e3c.bug # universal_robot/89145c4/89145c4.bug

fixed [no fork exists] in robust.py

f4d6b7e

created forks for 'turtlebot_create', 'rocon_app_platform', 'turtlebot_apps', 'cob_driver', 'cob_common', 'rqt', 'gazebo_ros_pkgs', 'ecl_core', 'openni_launch', 'qt_gui_core'

geometry2/0c3aef3/0c3aef3.bug is not fixed

73cd29f

care-o-bot/43705f7/43705f7.bug update PR

7bda2ba

update bug descriptions

bf3595c

added commit stats from fetch-commit-data script

bab581c

fix [no fork exists]

7195752

fix yamllint errors

7effbfa

not-fixed bugs

885c016

NOTABUG fix field is null

85a8ba1

Based on discussions

0b0c8cd

robust-rosin#408 robust-rosin#407

fix yamllint

ab73921

hsd-dev added 2 commits April 30, 2021 08:50

removed license field

ec48924

added file to identify descriptions that are not bugs

f5d14bd

hsd-dev force-pushed the fix_jupyter branch from 900fefe to f5d14bd Compare April 30, 2021 06:51

gavanderhoorn approved these changes Apr 30, 2021

View reviewed changes

hsd-dev merged commit 041df50 into robust-rosin:master May 3, 2021

hsd-dev deleted the fix_jupyter branch May 3, 2021 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix valid commit dict #399

fix valid commit dict #399

hsd-dev commented Feb 3, 2021 •

edited

Loading

ChrisTimperley commented Mar 16, 2021

hsd-dev commented Mar 16, 2021 •

edited

Loading

hsd-dev commented Mar 16, 2021

hsd-dev commented Apr 28, 2021

ChrisTimperley left a comment

gavanderhoorn commented Apr 28, 2021

This comment has been minimized.

hsd-dev commented Apr 30, 2021

hsd-dev commented Apr 30, 2021

gavanderhoorn commented Apr 30, 2021

hsd-dev commented Apr 30, 2021

gavanderhoorn commented Apr 30, 2021

hsd-dev commented May 3, 2021

fix valid commit dict #399

fix valid commit dict #399

Conversation

hsd-dev commented Feb 3, 2021 • edited Loading

ChrisTimperley commented Mar 16, 2021

hsd-dev commented Mar 16, 2021 • edited Loading

hsd-dev commented Mar 16, 2021

hsd-dev commented Apr 28, 2021

ChrisTimperley left a comment

Choose a reason for hiding this comment

gavanderhoorn commented Apr 28, 2021

This comment has been minimized.

hsd-dev commented Apr 30, 2021

hsd-dev commented Apr 30, 2021

gavanderhoorn commented Apr 30, 2021

hsd-dev commented Apr 30, 2021

gavanderhoorn commented Apr 30, 2021

hsd-dev commented May 3, 2021

hsd-dev commented Feb 3, 2021 •

edited

Loading

hsd-dev commented Mar 16, 2021 •

edited

Loading