Add opsgenie sink extra details from alert labels #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sk4mi
force-pushed
the
opsgenie-sink-extra-properties
branch
from
2fc8f99 to
5ebb2ce
Compare
arikalon1
reviewed
Oct 15, 2024
| @@ -96,6 +94,23 @@ def __to_description(self, finding: Finding, platform_enabled: bool) -> str: | |||
|
|
|||
| return f"{description}{self.__enrichments_as_text(finding.enrichments)}" | |||
|
|
|||
| def __to_details(self, finding: Finding, platform_enabled: bool) -> dict: | |||
There was a problem hiding this comment.
I think the platform_enabled parameter is not used
| } | ||
| lower_details_key = [k.lower() for k in details.keys()] | ||
| # Add extra details labels from config extra_details_labels if it exists | ||
| # without alterate details already present |
There was a problem hiding this comment.
I think there's a typo in the comment
There was a problem hiding this comment.
I rephrase it a little
sk4mi
force-pushed
the
opsgenie-sink-extra-properties
branch
from
5ebb2ce to
8245fb6
Compare
sk4mi
force-pushed
the
opsgenie-sink-extra-properties
branch
from
8245fb6 to
09c3fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to allow to add extra properties from alerts label to opsgenie