Implement 'roc format <dir_or_files>' command #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
reviewed
Nov 23, 2021
cli/src/format.rs
Outdated
| // files, | ||
| // roc_builtins::std::standard_stdlib(), | ||
| // Path::new("./generated-docs"), | ||
| // ) |
There was a problem hiding this comment.
🎨 Seems like this comment is no longer needed, yeah?
rtfeldman
reviewed
Nov 23, 2021
cli/src/format.rs
Outdated
|
|
||
| std::fs::write(&file, buf).unwrap(); | ||
| } | ||
| Err(error) => panic!("Unexpected parse failure when parsing this for module header formatting:\n\n{:?}\n\nParse error was:\n\n{:?}\n\n", src, error) |
There was a problem hiding this comment.
Instead of panic! can we use one of these? #2046
rtfeldman
reviewed
Nov 23, 2021
cli/src/main.rs
Outdated
| match maybe_values { | ||
| None => { | ||
| let mut os_string_values: Vec<OsString> = Vec::new(); | ||
| read_all_roc_files(&OsStr::new("./").to_os_string(), &mut os_string_values)?; |
There was a problem hiding this comment.
I think https://doc.rust-lang.org/std/env/fn.current_dir.html is probably more portable than "./"
joshuawarner32
force-pushed
the
joshuawarner32/roc-format-cmd
branch
from
c114fb6
to
1f16b95
Compare
ayazhafiz
reviewed
Nov 23, 2021
cli/src/main.rs
Outdated
| @@ -101,7 +101,7 @@ fn main() -> io::Result<()> { | |||
| match maybe_values { | |||
| None => { | |||
| let mut os_string_values: Vec<OsString> = Vec::new(); | |||
| read_all_roc_files(&OsStr::new("./").to_os_string(), &mut os_string_values)?; | |||
| read_all_roc_files(&std::env::current_dir().unwrap().as_os_str().to_os_string(), &mut os_string_values)?; | |||
There was a problem hiding this comment.
Can
Suggested change
| read_all_roc_files(&std::env::current_dir().unwrap().as_os_str().to_os_string(), &mut os_string_values)?; | |
| read_all_roc_files(&std::env::current_dir()?.as_os_str().to_os_string(), &mut os_string_values)?; |
be done here instead of an unwrap?
joshuawarner32
force-pushed
the
joshuawarner32/roc-format-cmd
branch
from
1f16b95
to
c017865
Compare
joshuawarner32
force-pushed
the
joshuawarner32/roc-format-cmd
branch
from
c017865
to
c5388ba
Compare
rtfeldman
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this was conspicuously missing.
Note when trying to format a roc few files in the repo, I immediately ran into missing parts of the formatter, which I'll work on next.
Having this command is both (1) independently useful, and (2) a good stepping stone to #2010, where we'll want to parse, simplify/reduce the ast, then write it out again (invoking the same code this does).