[WIP] Replace panic! and unreachable! with internal_error! #2409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone through the "low risk" packages listed in #2046 and replaced
panic!
andunreachable!
withinternal_error!
instead. Forpanic!
, I've just replaced the name and haven't changed any parameters. Forunreachable
, there are two different cases:unreachable!()
. In this case I replaced it withinternal_error!("unreachable")
, so that it's still clear that this should never happen.unreachable!("Any other pattern should have given a parse error")
. In this case, I've added "unreachable: " at the beginning of the string, again to make it clear that the code isn't expected to ever run.I just realized that I haven't used
user_error!
at all, so I will go through previous uses ofpanic!
and try to determine whereuser_error!
is better thaninternal_error!
.