Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/replace panic with internal error #5404

Closed

Conversation

eiei114
Copy link
Contributor

@eiei114 eiei114 commented May 13, 2023

This pull request contains changes that address the concerns raised in issue #2046.

@eiei114 eiei114 force-pushed the fix/replace_panic_with_internal_error branch from 9df1b5e to 13a826b Compare May 14, 2023 02:12
ayazhafiz
ayazhafiz previously approved these changes May 16, 2023
@eiei114
Copy link
Contributor Author

eiei114 commented May 17, 2023

@ayazhafiz
Will the failure of this test be resolved by me rewriting the code?

@ayazhafiz
Copy link
Member

Yes, please run cargo fmt and cargo clippy

@github-actions
Copy link

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

@eiei114
Copy link
Contributor Author

eiei114 commented Jun 23, 2023

I will resume this work.

@eiei114 eiei114 force-pushed the fix/replace_panic_with_internal_error branch from e5676cc to 6d16652 Compare June 24, 2023 07:45
@eiei114 eiei114 closed this Jun 25, 2023
@eiei114 eiei114 deleted the fix/replace_panic_with_internal_error branch June 25, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants