Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/replace_panic_with_internal_error #5601

Merged
merged 9 commits into from
Jul 1, 2023
Merged

fix/replace_panic_with_internal_error #5601

merged 9 commits into from
Jul 1, 2023

Conversation

eiei114
Copy link
Contributor

@eiei114 eiei114 commented Jun 25, 2023

This pull request contains changes that address the concerns raised in issue #2046

@eiei114
Copy link
Contributor Author

eiei114 commented Jun 25, 2023

cargo fmt and cargo clippy were done

ayazhafiz
ayazhafiz previously approved these changes Jun 27, 2023
View reviewed changes
@eiei114
Copy link
Contributor Author

eiei114 commented Jun 27, 2023

roc/Cargo.lock

 "roc_builtins",
 "roc_collections",
 "roc_error_macros", # <-here is 3783 line
 "roc_gen_llvm",
 "roc_load",
 "roc_module",
 "roc_mono",

Can I do a push with additions to roc/Cargo.lock?I want to add "roc_error_macros", on line 3783.

@eiei114
Copy link
Contributor Author

eiei114 commented Jun 27, 2023

I'm afraid of conflicts, but I'll push for it anyway.

@eiei114 eiei114 requested a review from ayazhafiz June 28, 2023 07:39
@bhansconnect bhansconnect merged commit 96b73d9 into roc-lang:main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhansconnect bhansconnect bhansconnect approved these changes

@ayazhafiz ayazhafiz Awaiting requested review from ayazhafiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eiei114 @bhansconnect @ayazhafiz