Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Purity inference #7170

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

[WIP] Purity inference #7170

wants to merge 49 commits into from

Conversation

agu-z
Copy link
Collaborator

@agu-z agu-z commented Oct 17, 2024 •
edited
Loading

Not quite ready for review yet, but only a few more cases to cover!

Type checking and errors preview:
https://www.youtube.com/watch?v=5a3r88-oEQQ

@ayazhafiz
Copy link
Member

ayazhafiz commented Oct 17, 2024 via email

@agu-z
Parse effectful arrow in function annotations
9e0feb0
@agu-z
Format effectful arrows in annotations
77098ab
@agu-z
Add effect_type to can ClosureData
da90175
@agu-z
Rename effect_type to fx_type and add to FunctionDef
b0f4972
@agu-z
Add fx var to Type::Function et al
369c796
@agu-z
Add fx var to can's Call
9378763
@agu-z
Remove irrelevant TODO
f5116dc
@agu-z
Unify call's fx var with that of the enclosing function
20185bb
@agu-z
Unify functions fx vars
5e6ae27
@agu-z
Do not use const fx vars when canonicalizing annotations
7e348ce
@agu-z
Constrain function annotation fx to body
a72fde1
@agu-z
Generate effectful hosted functions
4ae221e
@agu-z
Ignore unused fx vars in mono
f54f77c
@agu-z
Allow unsuffixed statements in parser
e345878 
Moves the "STATEMENT AFTER EXPRESSION" error from the parser to canonicalization.
We'll later use this to allow this case in effectful functions.
@agu-z
Parse lowercase idents ending in !
d333eb8
@agu-z
Do not attempt to parse ! suffix
e56a805
@agu-z
Desugar idents ending in ! to TrySuffix
71412dc
@agu-z
Restore parsing ! suffix
ed3a8f4 
This reverts commit 52896d9fa65141df832989b326f526cbedf67341.

We actually still need this for when `!` follows a non-ident expr
@agu-z
Add TODO to remove TryTarget::Task
02c8695
@agu-z
Detect fx mode based on hosted module
0d47240
@agu-z
Desugar stmt expr before checking whether it's suffixed
834a8ec
@agu-z
Canonicalize and constrain statement expr in purity inference mode
c2635d8
@agu-z
Leftover statement warning for pure statements
e829d49
@agu-z
Get suffix from IdentId or Symbol
bdf5aa7 
IdentId will now reserve the MSB for flagging whether the ident
is suffixed with a `!`.
We will use this later to constrain identifiers to be effectful or pure.
@agu-z
Switch fx mode based on platform main too
b95adea
@agu-z
Support ! in symbols provided to host
351dff5
@agu-z
Unsuffixed effectul function warning
fd5dd19
@agu-z
Suffixed pure function warning
fe48c91
@agu-z
Test aliased unsuffixed effectful function
4d25a10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agu-z @ayazhafiz