Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing field to testCreationAndDeinitializationWithFullConfig #102

Merged
merged 1 commit into from
May 13, 2023

Conversation

gavv
Copy link
Member

@gavv gavv commented May 13, 2023

No description provided.

@gavv gavv added the ready for review Pull request can be reviewed label May 13, 2023
@gavv gavv requested a review from ortex May 13, 2023 13:18
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #102 (9127df9) into main (b309665) will increase coverage by 1.67%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #102      +/-   ##
============================================
+ Coverage     73.03%   74.70%   +1.67%     
- Complexity       77       79       +2     
============================================
  Files            24       24              
  Lines           419      419              
  Branches          2        2              
============================================
+ Hits            306      313       +7     
+ Misses          109      102       -7     
  Partials          4        4              

see 2 files with indirect coverage changes

@ortex ortex merged commit 5550d93 into roc-streaming:main May 13, 2023
@gavv gavv removed the ready for review Pull request can be reviewed label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants