Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lombok for config builders #114

Merged
merged 16 commits into from
May 31, 2023
Merged

use lombok for config builders #114

merged 16 commits into from
May 31, 2023

Conversation

ortex
Copy link
Member

@ortex ortex commented May 20, 2023

fixed #110

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #114 (137bba8) into main (b433110) will increase coverage by 16.65%.
The diff coverage is 100.00%.

❗ Current head 137bba8 differs from pull request most recent head 704bc04. Consider uploading reports for the commit 704bc04 to get more accurate results

@@              Coverage Diff              @@
##               main     #114       +/-   ##
=============================================
+ Coverage     74.88%   91.53%   +16.65%     
  Complexity       81       81               
=============================================
  Files            24       24               
  Lines           422      260      -162     
  Branches          2        2               
=============================================
- Hits            316      238       -78     
+ Misses          102       18       -84     
  Partials          4        4               
Impacted Files Coverage Δ
.../java/org/rocstreaming/roctoolkit/RocReceiver.java 94.73% <ø> (ø)
...in/java/org/rocstreaming/roctoolkit/RocSender.java 84.21% <ø> (ø)
...n/java/org/rocstreaming/roctoolkit/RocContext.java 100.00% <100.00%> (ø)
.../org/rocstreaming/roctoolkit/RocContextConfig.java 100.00% <100.00%> (+31.57%) ⬆️
...org/rocstreaming/roctoolkit/RocReceiverConfig.java 100.00% <100.00%> (+48.64%) ⬆️
...a/org/rocstreaming/roctoolkit/RocSenderConfig.java 100.00% <100.00%> (+48.83%) ⬆️

@ortex ortex force-pushed the lombok-configs branch 4 times, most recently from bfe791a to ed5d19c Compare May 20, 2023 19:08
@ortex ortex force-pushed the lombok-configs branch from d8dba78 to 47c5fc2 Compare May 20, 2023 19:39
@gavv gavv added the ready for review Pull request can be reviewed label May 22, 2023
@gavv gavv merged commit 7b36e14 into main May 31, 2023
@gavv gavv deleted the lombok-configs branch May 31, 2023 13:28
@gavv
Copy link
Member

gavv commented May 31, 2023

Cool!

@gavv gavv removed the ready for review Pull request can be reviewed label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lombok to reduce boilerplate code in config classes
2 participants