Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine comments and validation for some config fields #118

Merged
merged 1 commit into from
May 31, 2023

Conversation

gavv
Copy link
Member

@gavv gavv commented May 31, 2023

No description provided.

@gavv gavv requested a review from ortex May 31, 2023 13:32
@gavv gavv added the ready for review Pull request can be reviewed label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #118 (378ff7a) into main (7b36e14) will decrease coverage by 0.62%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #118      +/-   ##
============================================
- Coverage     94.80%   94.18%   -0.62%     
- Complexity       80       81       +1     
============================================
  Files            24       24              
  Lines           250      258       +8     
  Branches          2        2              
============================================
+ Hits            237      243       +6     
- Misses            9       10       +1     
- Partials          4        5       +1     
Impacted Files Coverage Δ
.../org/rocstreaming/roctoolkit/RocContextConfig.java 100.00% <ø> (ø)
...rc/main/java/org/rocstreaming/roctoolkit/Slot.java 100.00% <ø> (ø)
...c/main/java/org/rocstreaming/roctoolkit/Check.java 83.33% <33.33%> (-16.67%) ⬇️
...org/rocstreaming/roctoolkit/RocReceiverConfig.java 100.00% <100.00%> (ø)
...a/org/rocstreaming/roctoolkit/RocSenderConfig.java 100.00% <100.00%> (ø)

@ortex ortex merged commit 49e243a into roc-streaming:main May 31, 2023
@gavv gavv removed the ready for review Pull request can be reviewed label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants