Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lombok builders #123

Merged
merged 1 commit into from
Jun 10, 2023
Merged

fix lombok builders #123

merged 1 commit into from
Jun 10, 2023

Conversation

ortex
Copy link
Member

@ortex ortex commented Jun 10, 2023

Need to use public access instead of protected for builders.
Public used by default

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #123 (e8d24a0) into main (2cae0e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #123   +/-   ##
=========================================
  Coverage     96.39%   96.39%           
  Complexity       90       90           
=========================================
  Files            24       24           
  Lines           305      305           
  Branches          2        2           
=========================================
  Hits            294      294           
  Misses            7        7           
  Partials          4        4           
Impacted Files Coverage Δ
.../org/rocstreaming/roctoolkit/RocContextConfig.java 100.00% <ø> (ø)
...org/rocstreaming/roctoolkit/RocReceiverConfig.java 100.00% <ø> (ø)
...a/org/rocstreaming/roctoolkit/RocSenderConfig.java 100.00% <ø> (ø)

@ortex ortex added the ready for review Pull request can be reviewed label Jun 10, 2023
@gavv gavv merged commit 21ecc17 into main Jun 10, 2023
@gavv gavv deleted the fix-lombok-builders branch June 10, 2023 10:44
@gavv gavv removed the ready for review Pull request can be reviewed label Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants