Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fixes in JNI code #64

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Cosmetic fixes in JNI code #64

merged 4 commits into from
Apr 1, 2023

Conversation

gavv
Copy link
Member

@gavv gavv commented Apr 1, 2023

This PR contains only stylistic mechanical changes:

  • added .clang-format config, which describes style close to what is currently used in code
  • added gradlew clangFormat task
  • run code formatting
  • remove extern "C" guards; they are not actually needed because guarded functions are used only from C++
  • use #pragma once instead of old-style guards

I've set line width limit to 100 characters. Let me know if it's too low.

@gavv gavv requested a review from ortex April 1, 2023 19:16
@ortex
Copy link
Member

ortex commented Apr 1, 2023

LGTM!

@ortex ortex merged commit d65d7ae into roc-streaming:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants