Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IFrameEncoder / IFrameDecoder using libvorbis #768

Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

runei
Copy link

@runei runei commented Jul 28, 2024

Implements #758

@github-actions github-actions bot added work in progress Pull request is still in progress and changing contribution A pull-request by someone else except maintainers labels Jul 28, 2024
@runei
Copy link
Author

runei commented Aug 9, 2024

Hi @gavv ,

The libvorbis build is successful for all targets except macos14-arm64/build-3rdparty and macos14-arm64/universal-binaries. But it works fine with macos14-arm64/standard-build and other macos builds.

The error message is:

*** Could not run Ogg test program, checking why...
*** The test program failed to compile or link. See the file config.log for the
*** exact error that occurred. This usually means Ogg was incorrectly installed
*** or that you have moved Ogg since it was installed.
configure: error: must have Ogg installed!

But according to the logs, libogg was installed before this error.

What is the difference between the macos 3rdparty, universal-binaries, to the other macos standard-build?
Do you have any suggestion on how to solve this issue?

@gavv
Copy link
Member

gavv commented Sep 15, 2024

Hi @gavv ,

The libvorbis build is successful for all targets except macos14-arm64/build-3rdparty and macos14-arm64/universal-binaries. But it works fine with macos14-arm64/standard-build and other macos builds.

The error message is:

...

Most likely, configure from libvorbis is trying to find libogg using pkg-config instead of using paths that we gave to it. In this case we can prevent it by providing OGG_CFLAGS and OGG_LIBS variables to configure, the same way as we do it with LIBSNDFILE_ when we're building pulseaudio (also in build-3rdparty.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution A pull-request by someone else except maintainers work in progress Pull request is still in progress and changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants