Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move VM naming from FreiburgSiteAdapter to Integration adapters #24

Open
cheidecker opened this issue May 19, 2017 · 2 comments
Open

Move VM naming from FreiburgSiteAdapter to Integration adapters #24

cheidecker opened this issue May 19, 2017 · 2 comments
Assignees

Comments

@cheidecker
Copy link
Collaborator

To support different naming conventions for the VMs in the FreiburgSiteAdapter, the following function needs to be moved to the corresponding IntegrationAdapters:
def __getVMName(self, batchJobId)

@Fra-nk
Copy link
Contributor

Fra-nk commented May 19, 2017

The name is usually determined by the site that boots the machine, not by the batch system.
Moving this to the integration adapter seems counter-intuitive.

Nevertheless you do have a valid point that duplicating the information from multiple adapters is a potential cause of errors.

@mschnepf
Copy link
Collaborator

Yes, the site adapter should know the hostname by booting.

The problem is that other batch systems like SLURM has a limited namespace of worker node. Only the batch system (integration adapter) know which hostnames can be used.

giffels pushed a commit to giffels/ROCED that referenced this issue Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants