Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards description #94

Merged

Conversation

rdenadai
Copy link
Contributor

@rochacbruno this an attempt to make it possible the description for the cards in the list.html.

I added a description to the Content struct, that could get filled with values in a description, if None we just fallback to the previous way (get from html and strip everything).

@rochacbruno
Copy link
Owner

The example dir is being our functional test, can you please add description to at least one of the posts on https://github.com/rochacbruno/marmite/tree/main/example/content so we can see it in action and ensure it does not break.

The example is build on CI for every PR.

@rdenadai rdenadai force-pushed the repeated-title-annoyance-complex branch from 07e5476 to e2d6dc7 Compare October 29, 2024 14:35
@rdenadai
Copy link
Contributor Author

The example dir is being our functional test, can you please add description to at least one of the posts on https://github.com/rochacbruno/marmite/tree/main/example/content so we can see it in action and ensure it does not break.

The example is build on CI for every PR.

Changed one of the templates inside example adding the description props...
https://github.com/rochacbruno/marmite/pull/94/files#diff-ed8d8eb0f5910129e1c418a133c868185f804343e9a303ef662ce4eb1115776cR5

@rdenadai rdenadai requested a review from rochacbruno October 29, 2024 14:37
@rochacbruno rochacbruno merged commit 4593064 into rochacbruno:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants