Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since Node 7.X, the execution of the command "npm version" seems to be hanged #8

Closed
rochejul opened this issue Jan 9, 2018 · 3 comments
Closed

Since Node 7.X, the execution of the command "npm version" seems to be hanged #8

rochejul opened this issue Jan 9, 2018 · 3 comments
Assignees
@rochejul
Labels
bug
Milestone
1.5.0

Comments

@rochejul
Copy link
Owner

rochejul commented Jan 9, 2018

Check that npmversion works fine on Node 8.X environment
@rochejul rochejul added this to the 1.5.0 milestone Jan 9, 2018
@rochejul rochejul self-assigned this Jan 9, 2018
@rochejul rochejul added bug and removed question labels Jan 10, 2018
@rochejul
Copy link
Owner Author

It seems running the command "npm version x.x.x" through the child_process.exec could never be terminated since NodeJs 7.X

Find a way to solve it

@rochejul
Copy link
Owner Author

Maybe us direclty the npm as nodejs module and use the version service: https://github.com/npm/npm/blob/latest/lib/version.js

@rochejul
Copy link
Owner Author

Could be related to sindresorhus/get-stdin#13 (comment) but it seems not working.

@rochejul rochejul changed the title Node 8.X investiguation Since Node 7.X, the execution of the command "npm version" seems to be hanged Jan 11, 2018
rochejul added a commit that referenced this issue Feb 19, 2018
@rochejul
Related to #8, to avoid hanging process with NodeJs 8.X or more
4bc4d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rochejul rochejul

Labels
bug
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@rochejul