Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add net-smtp as runtime dependency on ruby >= 3.1 #129

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

g-arjones
Copy link
Contributor

As of Ruby 3.1.0, net-smtp is not a default gem anymore...

@g-arjones g-arjones requested a review from doudou July 4, 2024 19:19
@g-arjones
Copy link
Contributor Author

@2maz Could you have a look at this, please?

@g-arjones g-arjones requested review from 2maz and removed request for doudou July 10, 2024 02:28
@g-arjones g-arjones force-pushed the add_net_smtp_as_dependency branch 2 times, most recently from 190b9b6 to 7182021 Compare July 10, 2024 18:17
@g-arjones g-arjones force-pushed the add_net_smtp_as_dependency branch from 7182021 to 195011f Compare July 10, 2024 18:21
@g-arjones
Copy link
Contributor Author

Workflows fixed.

Thanks for the review!

@g-arjones g-arjones merged commit eff2f5a into master Jul 10, 2024
6 checks passed
@g-arjones g-arjones deleted the add_net_smtp_as_dependency branch July 10, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants