Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow setting the type-export-policy to :all, it breaks compilation currently #14

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

goldhoorn
Copy link
Contributor

No description provided.

This PR sets back the export policy to :selected if :all is requested.
All curerntly fails on orogen. To keep the release compiling
the switch back was added.
@doudou
Copy link
Member

doudou commented May 22, 2015

I would rather NOT merge this back into master.

@goldhoorn
Copy link
Contributor Author

I would like to merge this in master because otherwise the OCL build does not work, Including buildserver and homepage generation.

The issue on orogen is available, so far this is a valid workaround. (orocos-toolchain/orogen#50).

As soon the issue is solved, this commit can be reverted.

@goldhoorn
Copy link
Contributor Author

@doudou either this or

rock-core/package_set#54

or the issue should be merged/fixed we cannot generate a homepage otherwiese
the current HP does not include all packages it's only a minimal build)

@doudou
Copy link
Member

doudou commented Jun 3, 2015

rock-core/package_set#54 has been merged, can we close this ?

@goldhoorn
Copy link
Contributor Author

The problem with base types still apply.
I would prefer to merged this and revert this when get merged the oroge bug get fixed.

@doudou
Copy link
Member

doudou commented Jun 3, 2015

Fair enough ...

@doudou doudou changed the title Automatic rock-release PR: integrate rc-patches in master Do not allow setting the type-export-policy to :all, it breaks compilation currently Jun 3, 2015
doudou added a commit that referenced this pull request Jun 3, 2015
Do not allow setting the type-export-policy to :all, it breaks compilation currently
@doudou doudou merged commit 454f280 into master Jun 3, 2015
@doudou doudou deleted the rock-rc branch June 3, 2015 13:24
@doudou doudou restored the rock-rc branch May 25, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants