Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the .NET runtime image include libicu? #10

Closed
cjdcordeiro opened this issue Jun 21, 2022 · 2 comments
Closed

should the .NET runtime image include libicu? #10

cjdcordeiro opened this issue Jun 21, 2022 · 2 comments
Assignees
Labels
requirements Refers to anything related with a potential requirement or spec definition for the product runtime

Comments

@cjdcordeiro
Copy link
Contributor

Since upstream includes it, I think it'd be wise to do as well. Though that'd be a change to Dockerfile.runtime, independent of commits in this PR.

Originally posted by @woky in #7 (comment)

@cjdcordeiro cjdcordeiro added requirements Refers to anything related with a potential requirement or spec definition for the product runtime labels Jun 22, 2022
@mthalman
Copy link
Collaborator

The libicu package adds a fair amount of size to the resulting image. And its use is optional for .NET apps. We've demonstrated with our .NET Alpine images, which also do not include ICU, that this is a popular offering. Since the purpose of this image type is to reduce things down to only what is necessary, I don't see a need to include an optional component like ICU. As long as there's decent documentation that demonstrates how to install libicu for customers, I think we'd be good.

@cjdcordeiro
Copy link
Contributor Author

ok thanks for the info. keeping libicu out of it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requirements Refers to anything related with a potential requirement or spec definition for the product runtime
Projects
None yet
Development

No branches or pull requests

3 participants