Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dotnet6 Dockerfile #7

Merged
merged 6 commits into from
Jun 21, 2022
Merged

Add dotnet6 Dockerfile #7

merged 6 commits into from
Jun 21, 2022

Conversation

woky
Copy link
Contributor

@woky woky commented Jun 14, 2022

Simple https fetch app currently fails

$ docker run -it -v $PWD/app:/app dotnet /app/bin/Debug/net6.0/Hello
Unhandled exception. System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
 ---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid because of errors in the certificate chain: PartialChain
   at System.Net.Security.SslStream.SendAuthResetSignal(ProtocolToken message, ExceptionDispatchInfo exception)

That should be fixed once canonical/chisel-releases#3
is merged.

README.md needs some love...

@cjdcordeiro
Copy link
Contributor

will test once canonical/chisel-releases#3 is merged.

@cjdcordeiro cjdcordeiro self-requested a review June 14, 2022 14:11
cjdcordeiro
cjdcordeiro requested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note the failing tests due to the Dockerfile name change

@woky woky force-pushed the woky-dotnet-image branch 2 times, most recently from 6dc34b9 to 30263eb Compare June 16, 2022 07:13
@woky
Copy link
Contributor Author

woky commented Jun 16, 2022

please note the failing tests due to the Dockerfile name change

@cjdcordeiro I've now fixed the tests and added test case for runtime image. I've also introduced little naming change.

  • runtime is image with .NET
  • runtime deps is image only with .NET dependencies

cjdcordeiro
cjdcordeiro requested changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments to be fixed. pls see comments inline

.github/workflows/test.yml Outdated Show resolved Hide resolved
Dockerfile.dotnet6 Outdated Show resolved Hide resolved
Dockerfile.dotnet6 Outdated Show resolved Hide resolved
Dockerfile.dotnet6 Outdated Show resolved Hide resolved
Dockerfile.dotnet6 Outdated Show resolved Hide resolved
tests/app_helloworld/runtest Outdated Show resolved Hide resolved
@woky
fix(ci): Run apt-get update before install skopeo
2bc68e6 
There's no guarantee that the apt cache in the image cache is
up-to-date.
@woky woky force-pushed the woky-dotnet-image branch 2 times, most recently from 1210eee to 7063d76 Compare June 21, 2022 08:13
woky added 5 commits June 21, 2022 10:14
@woky
refactor: Rename Dockerfile{ => .runtime-deps}
e7a20bb 
Also rename some workflow variables for consistency in anticipation of
runtime image addition in following commit.
@woky
refactor(test): Use host dotnet to build Hello World
7116642
@woky
feat: Add Dockerfile.runtime
4ade0fe 
This image contains .NET runtime. Currently it's retrieved from upstream
tarball. In future, it'll be chiseled.
@woky
feat: Add test for non-self-contained app
33dc7f8
@woky
feat: Ignore _test-results
c730391
@cjdcordeiro cjdcordeiro mentioned this pull request Jun 21, 2022
Closed
@cjdcordeiro cjdcordeiro removed their assignment Jun 21, 2022
@cjdcordeiro cjdcordeiro self-requested a review June 21, 2022 13:02
cjdcordeiro
cjdcordeiro approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @woky feel free to merge

@woky woky merged commit 6f74e97 into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees

@woky woky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woky @cjdcordeiro