aws_s3.cc: minor improve

rockeet · Oct 6, 2024 · 493723c · 493723c
1 parent bfd97aa
commit 493723c
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/cloud/aws/aws_s3.cc b/cloud/aws/aws_s3.cc
@@ -305,13 +305,12 @@ class S3ReadableFile : public CloudStorageReadableFileImpl {
           fname_.c_str(), offset, rangeLen);
       return IOStatus::IOError("S3ReadableFile vsnprintf ", fname_.c_str());
     }
-    Aws::String range(buffer);
 
     // set up S3 request to read this range
     Aws::S3::Model::GetObjectRequest request;
     request.SetBucket(ToAwsString(bucket_));
     request.SetKey(ToAwsString(fname_));
-    request.SetRange(range);
+    request.SetRange(Aws::String(buffer, ret));
 
     Aws::S3::Model::GetObjectOutcome outcome =
         s3client_->GetCloudObject(request);
@@ -332,7 +331,6 @@ class S3ReadableFile : public CloudStorageReadableFileImpl {
           fname_.c_str(), offset, buffer, error.GetMessage().c_str());
       return IOStatus::IOError(fname_, errmsg.c_str());
     }
-    std::stringstream ss;
     // const Aws::S3::Model::GetObjectResult& res = outcome.GetResult();
 
     // extract data payload
@@ -688,7 +686,7 @@ IOStatus S3StorageProvider::ExistsCloudObject(const std::string& bucket_name,
 IOStatus S3StorageProvider::GetCloudObjectSize(const std::string& bucket_name,
                                                const std::string& object_path,
                                                uint64_t* filesize) {
-  HeadObjectResult result;                                             
+  HeadObjectResult result;
   result.size = filesize;
   return HeadObject(bucket_name, object_path, &result);
 }