Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cuda version and drop cuda version tags for ubuntu:jammy based images #516

Merged
merged 12 commits into from
Oct 31, 2022

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Aug 17, 2022

close #282, close #503

We have maintained two rocker/cuda variants, cuda10.1 and cuda11.1, but now that the base image will be ubuntu:jammy, we will unify the cuda variants into one, as we can no longer use anything other than cuda11.7.X.

  1. cuda version tags, like rocker/cuda:cuda10.1, rocker/cuda:4.2.1-cuda10.1 will be obsolete for R 4.2.2 or later images.
  2. The aliases of rocker/cuda which was pushed to rocker/r-ver (rocker/r-ver:X.Y.Z-cuda10.1 and rocker/r-ver:X.Y.Z-cuda11.1) will be obsolete.

Only the R version tags like rocker/cuda:4.2.2, rocker/cuda:latest will remain.

Note: This Pull Request can only be merged after the R 4.2.2 release.

ToDo

  • Update stacks/4.2.1.json by hand.
    • Remove latest tags.
    • Change CRAN and CTAN urls.
  • Run ./build/make-stacks.R -> make clean -> make setup
  • Update NEWS.md
  • Update the reference page

- drop cuda10.1 images
- switch the base image to nvidia/cuda:11.7.1-cudnn8-devel-ubuntu22.04
@eitsupi eitsupi added documentation Improvements or additions to documentation enhancement New feature or request CI pre-built images Related to pre-built images labels Aug 17, 2022
@eitsupi eitsupi added this to the R 4.2.2 milestone Aug 17, 2022
@eitsupi eitsupi requested a review from cboettig August 17, 2022 14:48
@eitsupi eitsupi self-assigned this Aug 17, 2022
@eitsupi eitsupi changed the title Bump cuda version and drop cuda version tags Bump cuda version and drop cuda version tags for ubuntu:jammy based images Aug 17, 2022
Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good!

@@ -110,7 +110,7 @@ library(gert)
return(.url)
}

.cuda_baseimage_tag <- function(ubuntu_series, other_variants = "11.1.1-cudnn8-devel") {
.cuda_baseimage_tag <- function(ubuntu_series, other_variants = "11.7.1-cudnn8-devel") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worthwhile to automatically update the cuda version instead of hard-coding it.

@eitsupi eitsupi marked this pull request as ready for review October 31, 2022 10:05
@eitsupi
Copy link
Member Author

eitsupi commented Oct 31, 2022

I did a manual update as planned, so I'll merge this.

@eitsupi eitsupi merged commit 713610e into rocker-org:master Oct 31, 2022
@eitsupi eitsupi deleted the new-cuda branch October 31, 2022 10:08
@cboettig
Copy link
Member

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation enhancement New feature or request pre-built images Related to pre-built images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cuda versioning Swich the base image to Ubuntu 22.04 LTS
2 participants