Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove the feature to change the default non-root user name via USER env var #891

Merged
merged 4 commits into from
Dec 19, 2024
Merged

refactor!: remove the feature to change the default non-root user name via USER env var #891

merged 4 commits into from
Dec 19, 2024

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Dec 18, 2024 •
edited
Loading

Fix #489
Close #889

@eitsupi eitsupi requested a review from cboettig December 18, 2024 03:28
cboettig
cboettig approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely streamlined here, this makes sense to me!

@eitsupi eitsupi merged commit b7509ce into master Dec 19, 2024
@eitsupi eitsupi deleted the shouldnot-rename branch December 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboettig cboettig cboettig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eitsupi @cboettig