Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display schema types and fields in a styled box for improved view #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ademajagon
Copy link

No description provided.

@@ -19,7 +19,7 @@ export function Type({ schemaId, type }: TypeProps) {
}

return (
<div className="flex flex-col text-sm">
<div className="flex flex-col text-sm overflow-x-scroll custom-scrollbar p-2 bg-secondary-background rounded-2xl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @ademajagon - can you please provide a short description why this has changed. And if you don't mind a screenshot on how it looks

🚀 🚀 🙌

@kreshnnikgashi
Copy link
Member

Thanks again @ademajagon for your first contribution in our codebase - let's make debugger a cool project together 🚀 🚀

@ademajagon
Copy link
Author

Thank you, @kreshnnikgashi for your encouragement, Here's a screenshot of how it looks:
Screenshot from 2024-05-21 21-06-07

@kreshnnikgashi
Copy link
Member

kreshnnikgashi commented May 21, 2024

Thank you, @kreshnnikgashi for your encouragement, Here's a screenshot of how it looks

What do you think about turning the first box's top borders into rounded same as others ?
If you might as well have a look at JSON on the first box why it's not being displayed correctly
image

@kreshnnikgashi
Copy link
Member

I would add a little bit more padding inside the box:
image

@danstarns
Copy link
Member

I feel that we should remove the code rendering completely, and display a text box for each type and field. I think this would blend into the UI more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants