BN client Committees response optimizations #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jshufro
commented
May 8, 2023
•
jshufro
commented
- Change []beacon.Committee to an interface to reduce copying on the hot path
- Allow buffered decoding in the BN std-http-client
- Reuse []string buffers for bn committee responses
- Reuse json.Decoder objects (which have internal buffers) across calls to the beacon node's committees endpoint
jshufro
commented
May 9, 2023
…t path Allow buffered decoding in the BN std-http-client
jshufro
force-pushed
the
rolling-trees-prs
branch
2 times, most recently
from
383fe7a
to
2f18b81
Compare
jshufro
force-pushed
the
rolling-trees-prs
branch
from
2f18b81
to
9681749
Compare
|
Alrighty, in it goes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.