Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print rescue node plugin info even when the EC is syncing #419

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jshufro
Copy link
Contributor

@jshufro jshufro commented Dec 11, 2023

Since many people use Rescue Node to resync eth1 (or change clients), it would be ideal if rocketpool node status always printed the Rescue Node details when both the wallet is initialized and the plugin is enabled.

This will conflict with #418 so maybe merge that one first and I'll rebase

@0xfornax
Copy link
Member

#418 was merged if you want to do that rebase

@jshufro jshufro force-pushed the jms/rescue-addon-refactor branch 2 times, most recently from e5eb5be to 767749b Compare December 12, 2023 03:25
@jshufro
Copy link
Contributor Author

jshufro commented Dec 12, 2023

#418 was merged if you want to do that rebase

All set :)

@0xfornax
Copy link
Member

Would be nice to separate errors from the smartnode and the add-on to avoid things like this
image

@jshufro
Copy link
Contributor Author

jshufro commented Dec 12, 2023

Would be nice to separate errors from the smartnode and the add-on to avoid things like this image

Definitely not ideal, looking into it.

@jshufro
Copy link
Contributor Author

jshufro commented Dec 12, 2023

Pushed a fix. I forgot that fmt.Errorf wants %w for wrapping, and Printf wants %v for stringifying. Added linebreaks.

govet catches this. We really need to make an effort to get better CI static analysis.

@0xfornax
Copy link
Member

Thanks for the fixes. lgtm

@0xfornax 0xfornax merged commit a82a5f9 into rocket-pool:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants