Adjust execute() signature to BaseConnection::execute() #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting the PR! I will be upgrading our dbt integration to be compatible with dbt v1.7 shortly. When those changes are merged, the function signature will be updated. |
|
There is a new version available on PyPi now -> https://pypi.org/project/dbt-rockset/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already created a ticket via rockset UI, this PR might fix this.
However, I am unsure, if the limits needs to be respected.
During the execution of
dbt runwith a simple model (e.g. select one col from a table), I receive the following error.Problem:
The Baseclass (BaseConnectionManager) signature differs from the current implementation (https://github.com/dbt-labs/dbt-adapters/blob/main/dbt/adapters/base/connections.py#L398)
Might be related to #30