Skip to content

Commit

Permalink
remove references of deleted function TEST_SetFileDeletionDelay (#267)
Browse files Browse the repository at this point in the history
TEST_SetFileDeletionDelay has been removed. But I forgot to remove it from remote_compaction_test
  • Loading branch information
seckcoder authored Jul 10, 2023
1 parent cea8eb2 commit bded6cd
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions cloud/remote_compaction_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ class RemoteCompactionTest : public testing::Test {
clone_dir_ = test::TmpDir() + "/ctest";
cloud_fs_options_.TEST_Initialize("dbcloud.", dbname_);
cloud_fs_options_.keep_local_sst_files = true;
// To catch any possible file deletion bugs, cloud files are deleted
// right away
cloud_fs_options_.cloud_file_deletion_delay = std::nullopt;

options_.create_if_missing = true;
options_.create_missing_column_families = true;
Expand Down Expand Up @@ -105,7 +108,6 @@ class RemoteCompactionTest : public testing::Test {
// To catch any possible file deletion bugs, we set file deletion delay to
// smallest possible
auto* cimpl = static_cast<CloudFileSystemImpl*>(afs);
cimpl->TEST_SetFileDeletionDelay(std::chrono::seconds(0));
std::shared_ptr<FileSystem> fs(cimpl);
aenv_ = CloudFileSystem::NewCompositeEnv(base_env_, std::move(fs));
}
Expand Down Expand Up @@ -166,10 +168,6 @@ class RemoteCompactionTest : public testing::Test {
// Create new AWS env
ASSERT_OK(CloudFileSystem::NewAwsFileSystem(base_env_->GetFileSystem(),
copt, options_.info_log, &cfs));
// To catch any possible file deletion bugs, we set file deletion delay to
// smallest possible
auto* cimpl = static_cast<CloudFileSystemImpl*>(cfs);
cimpl->TEST_SetFileDeletionDelay(std::chrono::seconds(0));
// sets the env to be used by the env wrapper, and returns that env
env->reset(
new CompositeEnvWrapper(base_env_, std::shared_ptr<FileSystem>(cfs)));
Expand Down

0 comments on commit bded6cd

Please sign in to comment.