Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sys-4729] ignore table handler loading error when apply replication log record #275

Closed
wants to merge 1 commit into from

Conversation

seckcoder
Copy link

When follower applies kManifestWrite with newly added sst files, it also loads the table handlers and reads the footer blocks. If that fails due to leaf being overloaded, due to paranoid check, the shards will be errored permanently. Instead of erroring shards, it's actually safe to ignore the errors. But we still want to keep the paranoid checks, so adding a new parameter: ignore_table_load_error to VersionSet::LogAndApply function. If that's true, we force ignoring table handler loading error even if paranoid check is enabled.

@seckcoder
Copy link
Author

Igor reminded me that we ran with max_open_files=-1, so we can't ignore the error here since we make the assumption that meta->fd.table_reader is always non-null

@seckcoder seckcoder closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant