fix(purger): Fix the purger loop #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you pl update our ICLA as listed in https://github.com/rockset/rocksdb-cloud/blob/master/CONTRIBUTING.md? |
Closed
dhruba
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the purger loops forever without waiting for
purger_periodicity_millisbetween two runs. That's a bug. Additionally, when the purger is stopped, it waits the configured periodicity (10 minutes by default) before stopping. This is a real problem when one wants to gracefully shut down a DB.This PR fixes it.
By toggling the precondition of
wait_for, the purger now waits the right duration between two runs and shutdown on demand without waiting which is the intended behavior.