[DC-1265] Setup github action on java client repo #51
Conversation
kwadhwa18
changed the title
| - name: Build with Maven | ||
| env: | ||
| ROCKSET_APIKEY: ${{ secrets.ROCKSET_APIKEY }} | ||
| ROCKSET_APISERVER: ${{ secrets.ROCKSET_APISERVER }} |
There was a problem hiding this comment.
not really a secret but just in case
| cache: maven | ||
| - name: Build with Maven | ||
| env: | ||
| ROCKSET_APIKEY: ${{ secrets.ROCKSET_APIKEY }} |
There was a problem hiding this comment.
uses circle ci org - confirmed with Martin that we should use this for automated tests
There was a problem hiding this comment.
LGTM. This is great!
I'm nervious about someone accessing secrets by forking repository and submitting a review. By default, a maintainer needs to approve workflow runs before a fork one can run, according to this. Can you double check this is the case?
good idea, will check |
|
reviewed the permissions with Martin |
Run build and test on each commit and pull request on master
Successful run: https://github.com/rockset/rockset-java-client/actions/runs/4046897994/jobs/6960263220