-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DC-1265] Setup github action on java client repo #51
Conversation
- name: Build with Maven | ||
env: | ||
ROCKSET_APIKEY: ${{ secrets.ROCKSET_APIKEY }} | ||
ROCKSET_APISERVER: ${{ secrets.ROCKSET_APISERVER }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really a secret but just in case
cache: maven | ||
- name: Build with Maven | ||
env: | ||
ROCKSET_APIKEY: ${{ secrets.ROCKSET_APIKEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses circle ci org - confirmed with Martin that we should use this for automated tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is great!
I'm nervious about someone accessing secrets by forking repository and submitting a review. By default, a maintainer needs to approve workflow runs before a fork one can run, according to this. Can you double check this is the case?
good idea, will check |
reviewed the permissions with Martin |
Run build and test on each commit and pull request on master
Successful run: https://github.com/rockset/rockset-java-client/actions/runs/4046897994/jobs/6960263220