Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Concurrency in Java #167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rcardin
Copy link

@rcardin rcardin commented Nov 14, 2024

Hey, man. I finally did it. Here is the first version of the article on structured concurrency in Java.
Hope you like it!

Let me know if anything needs to be clarified.

Copy link
Collaborator

@daniel-ciocirlan daniel-ciocirlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing piece 👏
After a few hiccups at the beginning replicating what you've done, the flow was super smooth, and the explanations are top notch 👌

A few comments (mostly nits), then we can merge.
I have ideas.

src/content/articles/structured-concurrency-in-java.mdx Outdated Show resolved Hide resolved
src/content/articles/structured-concurrency-in-java.mdx Outdated Show resolved Hide resolved
src/content/articles/structured-concurrency-in-java.mdx Outdated Show resolved Hide resolved
src/content/articles/structured-concurrency-in-java.mdx Outdated Show resolved Hide resolved
src/content/articles/structured-concurrency-in-java.mdx Outdated Show resolved Hide resolved
src/content/articles/structured-concurrency-in-java.mdx Outdated Show resolved Hide resolved
@daniel-ciocirlan
Copy link
Collaborator

@rcardin please test the article and the site locally. For every tag that doesn't exist in the current set, we need to add a new JSON file under src/content/tags. For this article it means

  • src/content/tags/loom.json
  • src/content/tags/structured-concurrency.json

You can keep the JSONs empty. We have JSONs because we might need to add metadata later.

Also, for this article I recommend we use the tag concurrency instead of structured-concurrency.

@rcardin
Copy link
Author

rcardin commented Nov 15, 2024

@daniel-ciocirlan, I should have fixed all the issues. Please let me know if you see anything else.

@daniel-ciocirlan
Copy link
Collaborator

@rcardin I'll merge this next week when I have the video ready so that we can publish both at the same time.
Well done 👏

@andreilgeorgescu andreilgeorgescu removed their request for review November 21, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants