Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncaab boxscore not pulling with IDs #711

Open
danemiles opened this issue Mar 11, 2022 · 4 comments
Open

ncaab boxscore not pulling with IDs #711

danemiles opened this issue Mar 11, 2022 · 4 comments

Comments

@danemiles
Copy link

Describe the bug
boxscore is not consistently pulling game info (IndexError: list index out of range).

To Reproduce
Sample code which causes an issue.

from sportsipy.ncaab.boxscore import Boxscore
game_data1 = Boxscore('2021-03-28-14-gonzaga')

#issue also exists for example from the readthedocs website:
game_data = Boxscore('2018-04-02-21-villanova')

Expected behavior
Script should create detailed game boxscore.

Desktop (please complete the following information):

  • OS: MacOS 12.2.1 (Monterey)
  • Sportsipy Version: 0.6.0

Additional context
Wondering if this is error with HTML formatting. The following script does work:

from sportsipy.ncaab.boxscore import Boxscore
game_data2 = Boxscore('2016-02-02-michigan')

Code is being run in Google Colab.

@jkoestner
Copy link

i get the same issue, and think you are right it is something to do with format of html

@jkoestner
Copy link

i'll try to put a pull request at some point. it's actually not a bad fix. seems to be that section_header needs to be table_wrapper in scheme.

@reaganking
Copy link

Any solve @jkoestner? Don't want to open another issue as there are a handful already.

@jkoestner
Copy link

@reaganking yeah there is quite a few issues listed as you saw, and there was actually even an alternative solution that i didn't see #598.

It's a pretty easy fix, just changing 2 lines of code shown in #720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants