Fix failing NCAAB boxscore record parsing #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class names of NCAAB boxscore pages appears to have changed causing the parsing of the home and away records to fail. The scheme should be changed to account for the change. Signed-Off-By: Alex Wiss <alexwisswolf@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 56 +1
Lines 13178 13189 +11
=======================================
+ Hits 13175 13186 +11
Misses 3 3
Continue to review full report at Codecov.
|
|
@roclark anything else needed to get this merged? |
|
Is there a reason this hasn't been merged yet? |
This was referenced Mar 26, 2022
|
@alexwisswolf I had an alternative solution in #720 just changing the definitely agree to get one of these merged, as there is beginning to be a lot of duplicate issues. |
|
@jkoestner can't say I have a strong opinion on either solution, honestly. Would just be nice to get one of them merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to close #591 by tweaking the boxscore scheme according to suggestions that others have made in that issue. Appears to be working from what I can tell, but happy to change up the approach or add additional testing if required.