Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python code for new clean signature #194

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update Python code for new clean signature #194

merged 1 commit into from
Apr 3, 2023

Conversation

ctrueden
Copy link
Contributor

@ctrueden ctrueden commented Jan 25, 2023

The clean function now requires cmdclean and convert flags to be given.

Or you could keep backwards compatibility by adding default values:

def clean(self, cmdclean=True, convert=True):

The clean function now requires cmdclean and convert flags to be given.
@ctrueden
Copy link
Contributor Author

Also, the line:

    with PasswordStore('~/.password-store') as exporter:

did not work for me as written. You could consider changing it to:

    with PasswordStore(os.path.expanduser('~/.password-store')) as exporter:

Or do that internally inside the PasswordStore class.

@ctrueden
Copy link
Contributor Author

And thank you for this super useful tool! 🍻

@roddhjav roddhjav merged commit 6b3f7c0 into roddhjav:master Apr 3, 2023
@roddhjav
Copy link
Owner

roddhjav commented Apr 3, 2023

Thanks a lot. Merged. And also sorry for the delay.

@ctrueden ctrueden deleted the patch-1 branch April 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants