Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codegen.ml #31

Closed
wants to merge 1 commit into from
Closed

Conversation

marrious11
Copy link

@marrious11 marrious11 commented Mar 30, 2023

Hi sir @panglesd here are some proposed changes still commented. Awaits review/suggestions before I could make a full modification to issue #29.
Signed-off-by: Mario 66856309+marrious11@users.noreply.github.com

Proposed changes still commented. Awaits review/suggestions before I could make a full modification.
Signed-off-by: Mario <66856309+marrious11@users.noreply.github.com>
@panglesd
Copy link

panglesd commented Mar 30, 2023

Good efforts, and thanks for the PR! Unfortunately, I don't think the proposed modification really go toward a resolution of #29.

There is no need to replace match with function or use |> more often. What we want is to avoid raising (which is done here via the raise_errorf function). Instead, the errors should be collected, embedded at the right point in the AST, so that the execution can continue seamlessly.

@roddyyaga roddyyaga closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants