-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy Playground Layout Updates #87
Conversation
…low for long code snippets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure the best way to describe this (or what the right behavior is), but the resize
corner in the policy editor causes the parent widget to expand or contract. But on the playground, the resize doesn't affect the parent container at all:
Also I probably missed it, but is there a way to do trigger another evaluation? The only thing I could see to do was re-select a policy or resource.
I believe this is because the playground is using flex for the layout but the policy creation page is using flexbox. I think it would be better to be constrained to the parent container, do you agree? I will make an issue to update them to match.
Yeah, searching for a new policy or resource is the only way right now. I can add back the button to reset the playground or clear the policy/resource, but I figured once the user is able to edit the policy or resource fields then having the current screen would be the cleanest UI. I do have some ideas around adding a copy button to the blocks of code, so it could be a good place to add another button to remove the selected policy/resource |
Co-authored-by: Alex Ashley <alexa@liatrio.com>
@pickjasmine I agree it makes sense to limit them to the parent container, and also maybe to set |
I will add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes the playground to match the updated prototypes/the OPA Rego playground.