Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Search Filtering by Resource Type #98

Merged
merged 19 commits into from
Jun 1, 2021
Merged

Resource Search Filtering by Resource Type #98

merged 19 commits into from
Jun 1, 2021

Conversation

pickjasmine
Copy link
Contributor

@pickjasmine pickjasmine commented Jun 1, 2021 •
edited
Loading

  • Adds ability to filter resources by their type on the resource search page
    • Will show all resource types at all times
    • Viewing all resources will automatically remove the selected resource type filters
    • Changing only the search term will maintain type filters
  • Adds some constants to make life easier

Closes #83

@pickjasmine
Experiment with dropdown showing relevant resource types
a1f09a6
@pickjasmine
Update resource searching to handle resource filters, filtering on ba…
2332604 
…ckend works fine but UI is not helpful
@pickjasmine
Comments on todos, enable search button all the time, don't show all …
84bd0ad 
…keyword when viewing all resources or policies
@pickjasmine
Pull out a simple dropdown component
8d5561f
@pickjasmine
Styling of dropdown for themes
a4f6c82
@pickjasmine
Styles for error state, fix some view all issues for policies and res…
84ca731 
…ources
@pickjasmine
Clear filters when viewing all resources, show filters based on what …
55f91df 
…is in state
@pickjasmine
More styling improvements, functionality is as expected
e611602
@pickjasmine
Formatting, tests around dropdown component
dc6509b
@pickjasmine
Remove tests around disabling search button
a3b17f5
@pickjasmine
Tests around changes to searching for empty terms
175ddec
@pickjasmine
Tests around action changes to support filtering
89cdb19
@pickjasmine
Tests around resource params, more coverage
a9ba853
@pickjasmine
Tests around api changes
05d7dc6
@pickjasmine
Use constants for search all, const for resource type filter options
5a5acd9
@pickjasmine
Update cypress selectors to reflect changes to searching
9aafb13
@pickjasmine
Use resource types const in tests for more confidence
14e1349
@pickjasmine
Add parens to do filtering the way you would expect
c28354a
@pickjasmine
Clean up old comments
c48502c
@pickjasmine pickjasmine merged commit 926ed86 into main Jun 1, 2021
@pickjasmine pickjasmine deleted the search-filters branch June 1, 2021 19:06
@pickjasmine pickjasmine mentioned this pull request Jun 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search Filters
2 participants
@pickjasmine @mrparkers