fix: lighthouse test for dashboard needs local storage

rodekruis · Mar 4, 2021 · 280e7d8 · 280e7d8
1 parent 413f2e2
commit 280e7d8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/interfaces/IBF-dashboard/src/app/components/login-form/login-form.component.html b/interfaces/IBF-dashboard/src/app/components/login-form/login-form.component.html
@@ -35,6 +35,7 @@
   <ion-button
     buttonType="button"
     type="submit"
+    class="login-button"
     expand="block"
     [disabled]="!loginForm.form.valid"
   >

diff --git a/interfaces/IBF-dashboard/src/app/services/jwt.service.ts b/interfaces/IBF-dashboard/src/app/services/jwt.service.ts
@@ -9,15 +9,15 @@ export class JwtService {
   private jwtHelper = new JwtHelperService();
 
   public getToken(): string | undefined {
-    return window.sessionStorage[this.tokenKey];
+    return window.localStorage[this.tokenKey];
   }
 
   public saveToken(token: string): void {
-    window.sessionStorage[this.tokenKey] = token;
+    window.localStorage[this.tokenKey] = token;
   }
 
   public destroyToken(): void {
-    window.sessionStorage.removeItem(this.tokenKey);
+    window.localStorage.removeItem(this.tokenKey);
   }
 
   public decodeToken(rawToken: string): any {

diff --git a/tests/lighthouse/lighthouserc.js b/tests/lighthouse/lighthouserc.js
@@ -13,7 +13,11 @@ module.exports = {
             puppeteerScript: "./tests/lighthouse/login-script.js",
             puppeteerLaunchOptions: {
                 defaultViewport: null,
-                args: ["--disable-gpu --window-size=1280,720", "--no-sandbox"],
+                args: [
+                    "--disable-gpu",
+                    "--window-size=1280,720",
+                    "--no-sandbox",
+                ],
                 headless: true,
             },
             headful: false,

diff --git a/tests/lighthouse/login-script.js b/tests/lighthouse/login-script.js
@@ -5,7 +5,7 @@ const LOGIN_PASSWORD = process.env.LOGIN_PASSWORD;
 const locators = {
     inputLoginEmail: 'input[type="email"]',
     inputLoginPassword: 'input[type="password"]',
-    loginForm: ".login-form",
+    loginButton: ".login-button",
 };
 
 module.exports = async (browser, context) => {
@@ -25,7 +25,7 @@ module.exports = async (browser, context) => {
         const passwordInput = await page.$(locators.inputLoginPassword);
         await passwordInput.type(LOGIN_PASSWORD);
         await Promise.all([
-            page.$eval(locators.loginForm, form => form.submit()),
+            page.$eval(locators.loginButton, button => button.click()),
             page.waitForNavigation({ waitUntil: "networkidle0" }),
         ]).catch(function (err) {
             console.log("Login Failed");