Patch service to default to systemd on Debian 9 #720
Conversation
Puppet 4.8.x systemd provider does not recognize Debian 9 (Stretch), it thus fall back to runit and the spec fails with: Could not find the daemon directory (tested [/etc/sv,/var/lib/service]) Tested using: PUPPET_GEM_VERSION='4.8.2' bundle install bundle exec rspec ./spec/classes/relationship__titles_spec.rb References: puppetlabs/puppet@d5a69fb https://phabricator.wikimedia.org/T203645
|
Debian Stretch comes with puppet 4.8.2, the Debian package has been patched but the gem from rubygems.org is not. A potential fix is to add to every spec_helpers: I would rather have it handled by rspec-puppet :] |
| # https://github.com/puppetlabs/puppet/commit/d5a69fb57c15683873b422cb5e17ef06ca13cea5 | ||
| if Puppet::Util::Package.versioncmp(Puppet.version, '4.8.0') >= 0 && Puppet::Util::Package.versioncmp(Puppet.version, '4.10.0') < 0 | ||
| Puppet::Type.type(:service).provide(:systemd).instance_eval do | ||
| defaultfor :operatingsystem => :debian |
There was a problem hiding this comment.
This condition is incorrect, as it will make tests for Debian < 8.0 fail or be inaccurate (those systems don't use systemd).
Also, the condition set in puppet 4.10.x is still wrong and overridden in the debian pacakges to this day.
The correct condition would probably be:
- Monkey-patch all versions that include a systemd provider and offer the defaultfor method for providers
- Add a specific defaultfor to the "debian" provider for debian versions up to 7 (you can limit yourself to 5,6,7)
- Add this defaultfor
There was a problem hiding this comment.
And on further discussion, @lavagetto pointed that the patch modifies the behavior of the puppet interpreter. That could potentially hide an issue when running puppet from Gem, but I guess everyone just use the patched up puppet debian package.
|
We see the same problem is there an open issue to this PR? |
|
I'm very uncomfortable with this change as it is modifying the underlying puppet's behaviour. Since these test results seem to reflect reality (wrong behaviour on debian), please do patch your puppet version to not exhibit buggy behaviour, or upgrade to a version that is actually supported and maintained. |
|
The Puppet version shipped by Debian is patched. The issue lies in the Puppet 4.8 / 4.10 rubygems which, being no more supported at the time, lacked the bit to flag Then Stretch / Puppet 4.x are old, so probably we should not bother with this PR anymore. |
Puppet 4.8.x systemd provider does not recognize Debian 9 (Stretch), it
thus fall back to runit and the spec fails with:
Could not find the daemon directory (tested [/etc/sv,/var/lib/service])
Tested using:
PUPPET_GEM_VERSION='4.8.2' bundle install
bundle exec rspec ./spec/classes/relationship__titles_spec.rb
References:
puppetlabs/puppet@d5a69fb
https://phabricator.wikimedia.org/T203645