Fix support for rspec-expectations
3.8.5+
#767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds value expectation support to RSpec's built-in
raise_error
matcher that is quite often used in projects usingrspec-puppet
, e.g.:Also, since block matchers are more strict by default and don't accept value targets (defined as lambdas), this change adds an indicator that built-in
rspec-puppet
matchers do support value expectations as well as block expectations. This means that both:will work.
I'm not 100% certain this will work. Tested with https://github.com/voxpupuli/puppet-cassandra.
Appreciate if you can point out.
cc @alexjfisher @cyberious do you mind testing this against some of the projects depending on
rspec-puppet
that you maintain?Related:
RSpec issue regarding the removal of implicit block syntax in a patch version rspec/rspec-expectations#1134
RSpec pull request with the removal rspec/rspec-expectations#1125
https://blog.rubystyle.guide/rspec/2019/07/17/rspec-implicit-block-syntax.html
rubocop/rspec-style-guide#76