Incorrect indentation after heredoc or multiline string that includes empty lines

[alexjfisher]

If a heredoc, (or a simple multiline string), contains a blank line, the indentation of resources that follow is removed.

eg.

class foo {
  $content = @("HERE")
  This heredoc is fine
  | HERE

  file { 'test':
    content => $content,
  }

  $content2 = @(HERE)
    So is this one
    | HERE

  file { 'test2':
    content => $content2,
  }

  $content3 = @(HERE)
    But a heredoc with a blank line in it...

    ... isn't
    (file resource below is not indented as it should be)
    | HERE

file { 'test3':
  content => $content3,
}
}

and

class foo {
  $str = 'foo

  bar'

# multiline string with blank line also causes following lines to be incorrectly indented.
notify { 'test':
  message => $str,
}
}

[alexjfisher]

Possibly related, if a multiline string (or heredoc) contains a line that consists of only whitespace, the plugin currently removes all of this. It should probably leave it alone, (ie never touch the contents of a multiline string)??

[alexjfisher]

In the case of a blank line inside a multiline string, (either deliberately, or because all existing whitespace was just removed??), the function InsideMultilineString then incorrectly returns false.

[lelutin]

thanks for reporting this @alexjfisher

I can reproduce the issue with $content3 in your example above and also with the normal string, thanks for the reproducers! from what I can see, everything that follows the heredoc or string with a blank line has its indentation wrong, not just the resource right after

I can also reproduce the issue with a line that only has blank spaces inside of a heredoc with this:

  $content4 = @(HERE)
    heredoc with a line with only spaces
                 
    should stay exactly like it is
    | HERE

  $str2 = 'blah
  
  meuh'

we can start a pull request just with those examples in a test. then we can start looking for the solution.

I'll create the pull request ~soon if you don't beat me to it :)