Refactor fish scripts for fisher #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 1, 2021 12:03
Follow fisher's recommended filename for file https://github.com/jorgebucaran/fisher/tree/56c629a3a9086f33eeae801598b2046cab9bea6b#event-system.
Follow fisher's recommendation jorgebucaran/fisher#651 (comment).
Follow fisher's recommendation jorgebucaran/fisher#651 (comment).
Quote variables to fix fish linter error about missing argument for --on-event. Follow fisher's recommended filename for file https://github.com/jorgebucaran/fisher/tree/56c629a3a9086f33eeae801598b2046cab9bea6b#event-system.
|
Looks good on glance, but not sure i know how to test/repicate at this point since the offending plugin is updated |
added 2 commits
March 2, 2021 13:13
Fixed typo in install function name.
Removed curly braces from variables, their values were including these—e.g. fish_apple_touchbar{_install}.
Disable markdownlint MD036 warning for specific line (exception).
|
Tested changes by installing plugin from branch fisher install rodrigobdz/fish-apple-touchbar@refactor-fish-scripts-for-fisher
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
See commit messages for further details.