An attempt to make clippy and rustc complain less
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why this does not break ABI: MaybeUninit and ManuallyDrop keep the ABI, and `#[repr(C)]` keeps overall ABI when fields are kept as is
|
Sorry for a total mess of a PR, but I just actually don't know if this is maintained and what direction other people want this project moving. |
timotheyca
commented
Dec 19, 2024
| @@ -4,10 +4,6 @@ This is the changelog, summarising changes in each version | |||
|
|
|||
| Minor changes may be ommited, as well as improvements to documentation. | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| Bumped MSRV to 1.63 (`libc` crate requires it). | |||
There was a problem hiding this comment.
yes, I to forgot actually change the version in Cargo.toml and only wrote it in the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this as a draft PR, since there are somewhat many changes (I doubt anyone would be willing to review them all at once — I'll probably make separate PRs for each specific thing — just need some feedback on which of these are worth it; plus my fork currently has some changes which are just taste-based).
What I did (the important parts):
#[repr(C, u8)]onenums. The wayenums are currently handled seems to be potentially unsound.default-features(default_featuresis deprecated).#[non_exhaustive]onstructs.PhantomDatafied unusedtuplefields.target_pointer_width = "128".cfg(x86_64)tocfg(target_arch = "x86_64").ScratchSpaceInner(keeping the same ABI as far as I understand) to have better user experience (fewer warnings) at the cost of slightly more complex definition and construction (should not impact runtime at all).constnames to_where that made sense.///s — see#[sabi_trait]with#[warn(clippy::empty_docs)]#116.#[allow(clippy::needless_lifetimes)],#[allow(non_camel_case_types)]and#[allow(clippy::unnecessary_cast)]inproc-macros