Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string and path concatenation operators #23

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Add string and path concatenation operators #23

merged 3 commits into from
Jan 31, 2019

Conversation

rofinn
Copy link
Owner

@rofinn rofinn commented Jan 29, 2019

Closes #2

Repository owner deleted a comment from codecov-io Jan 30, 2019
src/path.jl Show resolved Hide resolved
src/path.jl Outdated Show resolved Hide resolved
src/path.jl Outdated Show resolved Hide resolved
Co-Authored-By: rofinn <rory.finnegan@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #23 into master will decrease coverage by 4.39%.
The diff coverage is 62.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #23     +/-   ##
========================================
- Coverage    86.6%   82.2%   -4.4%     
========================================
  Files           8       8             
  Lines         448     444      -4     
========================================
- Hits          388     365     -23     
- Misses         60      79     +19
Impacted Files Coverage Δ
src/status.jl 100% <ø> (ø) ⬆️
src/posix.jl 60% <0%> (-4%) ⬇️
src/windows.jl 77.27% <0%> (-4.55%) ⬇️
src/FilePathsBase.jl 54.54% <100%> (ø) ⬆️
src/libc.jl 63.33% <33.33%> (-3.34%) ⬇️
src/path.jl 87.5% <80%> (-3.61%) ⬇️
src/utils.jl 90% <0%> (-10%) ⬇️
src/mode.jl 85.39% <0%> (-6.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff9713...6f4b0e2. Read the comment docs.

@rofinn
Copy link
Owner Author

rofinn commented Jan 31, 2019

Thanks for reviewing!

@rofinn rofinn merged commit 93482e9 into master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants