fix: use dynohook for take damage old for compatibility#1159
Merged
roflmuffin merged 6 commits intomainfrom Dec 23, 2025
Merged
fix: use dynohook for take damage old for compatibility#1159roflmuffin merged 6 commits intomainfrom
roflmuffin merged 6 commits intomainfrom
Conversation
This was referenced Dec 23, 2025
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hook Result Behaviour Comparison
This PR changes the dyno hook handling to be somewhat more consistent with other hook pattern handling, in that a hook result of
Stopwill prevent other hooks from running immediately. It will also prevent anyPosthooks from running if the result isHandledorStop. This was required for cases such as "TakeDamageOld" which should not run the post damage hook if the damage has been prevented by a plugin in CS#.It also adds a way for dyno hook hooks to be added on the native side.