fix: Ensure compatibility with CS2Fixes
#1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks good to me. Could we remove the commented out code from the old file and then I'll merge? |
Contributor
Author
updated |
Contributor
Author
Side note:possibly related to #1148 as well, not sure |
roflmuffin
approved these changes
Dec 28, 2025
This was referenced Dec 29, 2025
mrc4tt
pushed a commit
to mrc4tt/CounterStrikeSharp
that referenced
this pull request
Dec 31, 2025
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1151
#1151 (comment)
this pr fixes the crash on windows at least, linux is untested
Root cause:
CS# hooks
CBaseEntity_TakeDamageOldat startup, but CS2Fixes needs to hook it too, since CS# loads before CS2Fixes, once CS# hooks the function, CS2Fixes can no longer find the original signature in memory (leading to errors)Fix:
we now only cache the memory address of
CBaseEntity_TakeDamageOldduring CS# startup, then defer the actual hook until all Metamod plugins have finished loading