Fix handling of root flags in RequirePermissionsOr #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KillStr3aK
reviewed
Dec 4, 2024
Comment on lines
+14
to
+16
| public override bool CanExecuteCommand(SteamID? steamID) | ||
| { | ||
| if (caller == null) return true; | ||
| if (AdminManager.PlayerHasCommandOverride(caller, Command)) | ||
| if (steamID == null) return true; |
There was a problem hiding this comment.
It should be. SteamID null checks are peppered throughout core AdminManager functions, including PlayerHasCommandOverride itself, and I haven't seen any bug reports these functions failing.
roflmuffin
reviewed
Dec 16, 2024
| @@ -27,13 +27,15 @@ public BaseRequiresPermissions(params string[] permissions) | |||
| Command = ""; | |||
| } | |||
|
|
|||
| public virtual bool CanExecuteCommand(CCSPlayerController? caller) | |||
| public virtual bool CanExecuteCommand(SteamID? steamID) | |||
There was a problem hiding this comment.
Is this a public API? We might need to keep the old prototype around for backwards compatibility, and then proxy it to the new method using caller.AuthorizedSteamID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #699.