manual isolate dispose (#26)

* manual isolate dispose

* Add close method for context

context.go

@@ -59,6 +59,11 @@ func (c *Context) RunScript(source string, origin string) (*Value, error) {
 	return getValue(rtn), getError(rtn)
 }
 
+// Close will dispose the context and free the memory.
+func (c *Context) Close() {
+	c.finalizer()
+}
+
 func (c *Context) finalizer() {
 	C.ContextDispose(c.ptr)
 	c.ptr = nil

context_test.go

@@ -1,6 +1,8 @@
 package v8go_test
 
 import (
+	"encoding/json"
+	"fmt"
 	"testing"
 
 	"rogchap.com/v8go"
@@ -58,3 +60,17 @@ func TestJSExceptions(t *testing.T) {
 		})
 	}
 }
+
+func BenchmarkContext(b *testing.B) {
+	b.ReportAllocs()
+	vm, _ := v8go.NewIsolate()
+	defer vm.Close()
+	for n := 0; n < b.N; n++ {
+		ctx, _ := v8go.NewContext(vm)
+		ctx.RunScript(script, "main.js")
+		str, _ := json.Marshal(makeObject())
+		cmd := fmt.Sprintf("process(%s)", str)
+		ctx.RunScript(cmd, "cmd.js")
+		ctx.Close()
+	}
+}

isolate.go

@@ -75,3 +75,8 @@ func (i *Isolate) finalizer() {
 	i.ptr = nil
 	runtime.SetFinalizer(i, nil)
 }
+
+// Close will dispose the Isolate VM; subsequent calls will panic
+func (i *Isolate) Close() {
+	i.finalizer()
+}

isolate_test.go

@@ -1,6 +1,9 @@
 package v8go_test
 
 import (
+	"encoding/json"
+	"fmt"
+	"math/rand"
 	"strings"
 	"testing"
 	"time"
@@ -48,3 +51,45 @@ func TestGetHeapStatistics(t *testing.T) {
 		t.Error("expect NumberOfDetachedContexts return 0, got", hs.NumberOfDetachedContexts)
 	}
 }
+
+func BenchmarkIsolateInitialization(b *testing.B) {
+	b.ReportAllocs()
+	for n := 0; n < b.N; n++ {
+		vm, _ := v8go.NewIsolate()
+		vm.Close() // force disposal of the VM
+	}
+}
+
+func BenchmarkIsolateInitAndRun(b *testing.B) {
+	b.ReportAllocs()
+	for n := 0; n < b.N; n++ {
+		vm, _ := v8go.NewIsolate()
+		ctx, _ := v8go.NewContext(vm)
+		ctx.RunScript(script, "main.js")
+		str, _ := json.Marshal(makeObject())
+		cmd := fmt.Sprintf("process(%s)", str)
+		ctx.RunScript(cmd, "cmd.js")
+		ctx.Close()
+		vm.Close() // force disposal of the VM
+	}
+}
+
+const script = `
+	const process = (record) => {
+		const res = [];
+		for (let [k, v] of Object.entries(record)) {
+			res.push({
+				name: k,
+				value: v,
+			});
+		}
+		return JSON.stringify(res);
+	};
+`
+
+func makeObject() interface{} {
+	return map[string]interface{}{
+		"a": rand.Intn(1000000),
+		"b": "AAAABBBBAAAABBBBAAAABBBBAAAABBBBAAAABBBB",
+	}
+}

v8go.cc

@@ -188,32 +188,17 @@ void ContextDispose(ContextPtr ptr) {
         return;
     }
     m_ctx* ctx = static_cast<m_ctx*>(ptr);
-    Isolate* iso = ctx->iso;
-    Locker locker(iso);
-    Isolate::Scope isolate_scope(iso);  
-
-    ctx->ptr.Reset();  
+    if (ctx == nullptr) {
+        return;
+    }
+    ctx->ptr.Reset(); 
     delete ctx;
 } 
 
 /********** Value **********/
 
 void ValueDispose(ValuePtr ptr) {
-  m_value* val = static_cast<m_value*>(ptr);
-  if (val == nullptr) {
-    return;
-  }
-  m_ctx* ctx = val->ctx_ptr;
-  if (ctx == nullptr) {
-    return;
-  }
-
-  Isolate* iso = ctx->iso;
-  Locker locker(iso);
-  Isolate::Scope isolate_scope(iso);
-
-  val->ptr.Reset();
-  delete val;
+  delete static_cast<m_value*>(ptr);
 }
 
 const char* ValueToString(ValuePtr ptr) {
@@ -241,11 +226,3 @@ const char* Version() {
 
 }
 
-
-int _main(int argc, char* argv[]) {
-    Init();
-    auto i = NewIsolate();
-    auto c = NewContext(i);
-    RunScript(c, "18 + 17", "");
-    return 0;
-}